Re: [PATCH] pm-graph: Refactor installation script

From: Rafael J. Wysocki
Date: Mon Nov 04 2024 - 11:21:40 EST


On Fri, Nov 1, 2024 at 3:53 PM Amit Vadhavana <av2082000@xxxxxxxxx> wrote:
>
> Change installation script to ensure that the terminal returns to the
> original directory after the installation process completes.
>
> Signed-off-by: Amit Vadhavana <av2082000@xxxxxxxxx>
> ---
> tools/power/pm-graph/install_latest_from_github.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/power/pm-graph/install_latest_from_github.sh b/tools/power/pm-graph/install_latest_from_github.sh
> index eaa332399d36..aaf3515400ed 100755
> --- a/tools/power/pm-graph/install_latest_from_github.sh
> +++ b/tools/power/pm-graph/install_latest_from_github.sh
> @@ -4,6 +4,9 @@
> # Script which clones and installs the latest pm-graph
> # from http://github.com/intel/pm-graph.git
>
> +# Save the current directory
> +CURRENT_DIR=$(pwd)
> +
> OUT=`mktemp -d 2>/dev/null`
> if [ -z "$OUT" -o ! -e $OUT ]; then
> echo "ERROR: mktemp failed to create folder"
> @@ -36,3 +39,6 @@ else
> echo "INSTALL FAILED"
> fi
> cleanup
> +
> +# Return to the original directory
> +cd "$CURRENT_DIR"
> --

Todd, can you please let me know if this is OK?