Re: [PATCH 1/1] perf tests: Remove dangling CFLAGS for removed attr.o object

From: Ian Rogers
Date: Mon Nov 04 2024 - 15:38:15 EST


On Mon, Nov 4, 2024 at 6:35 AM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
>
> Since the C test wrapper for attr.py was removed we don't have an attr.o
> object for that CFLAGS_attr.o to apply for, remove it.
>
> Fixes: 3a447031f5fc21c4 ("perf test: Remove C test wrapper for attr.py")
> Cc: Athira Rajeev <atrajeev@xxxxxxxxxxxxxxxxxx>
> Cc: Howard Chu <howardchu95@xxxxxxxxx>
> Cc: Ian Rogers <irogers@xxxxxxxxxx>
> Cc: James Clark <james.clark@xxxxxxxxxx>
> Cc: Leo Yan <leo.yan@xxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Cc: Thomas Richter <tmricht@xxxxxxxxxxxxx>
> Cc: Veronika Molnarova <vmolnaro@xxxxxxxxxx>
> Cc: Weilin Wang <weilin.wang@xxxxxxxxx>
> Cc: Ze Gao <zegao2021@xxxxxxxxx>
> Cc: zhaimingbing <zhaimingbing@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> ---
> tools/perf/tests/Build | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
> index 03cbdf7c50a09be4..01ed9335db4dba4e 100644
> --- a/tools/perf/tests/Build
> +++ b/tools/perf/tests/Build
> @@ -72,7 +72,6 @@ ifeq ($(SRCARCH),$(filter $(SRCARCH),x86 arm arm64 powerpc))
> perf-test-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o
> endif
>
> -CFLAGS_attr.o += -DBINDIR="BUILD_STR($(bindir_SQ))" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
> CFLAGS_python-use.o += -DPYTHONPATH="BUILD_STR($(OUTPUT)python)" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
> CFLAGS_dwarf-unwind.o += -fno-optimize-sibling-calls
>
> --
> 2.47.0
>