RE: [PATCH 2/2] iio: adc: vf610_adc: limit i.MX6SX's channel number to 4

From: Bough Chen
Date: Mon Nov 04 2024 - 21:09:51 EST


> -----Original Message-----
> From: Frank Li <frank.li@xxxxxxx>
> Sent: 2024年11月5日 7:12
> To: Bough Chen <haibo.chen@xxxxxxx>; Jonathan Cameron
> <jic23@xxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; open list:NXP i.MX
> 7D/6SX/6UL/93 AND VF610 ADC DRIVER <linux-iio@xxxxxxxxxxxxxxx>; open
> list:NXP i.MX 7D/6SX/6UL/93 AND VF610 ADC DRIVER <imx@xxxxxxxxxxxxxxx>;
> open list <linux-kernel@xxxxxxxxxxxxxxx>
> Subject: [PATCH 2/2] iio: adc: vf610_adc: limit i.MX6SX's channel number to 4
>
> i.MX6SX only has 4 ADC channels, so limit channel numbers to 4 for compatible
> string 'fsl,imx6sx-adc'.

Reviewed-by: Haibo Chen <haibo.chen@xxxxxxx>

Best Regards
Haibo Chen
>
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> compatible string 'fsl,imx6sx-adc' already document in
> Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml
> ---
> drivers/iio/adc/vf610_adc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c index
> 4e737b193c012..84573cdfce5da 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -809,7 +809,8 @@ static const struct iio_info vf610_adc_iio_info = { };
>
> static const struct of_device_id vf610_adc_match[] = {
> - { .compatible = "fsl,vf610-adc", },
> + { .compatible = "fsl,imx6sx-adc", .data = (void *)4},
> + { .compatible = "fsl,vf610-adc", .data = (void
> +*)ARRAY_SIZE(vf610_adc_iio_channels)},
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, vf610_adc_match); @@ -870,7 +871,7 @@
> static int vf610_adc_probe(struct platform_device *pdev)
> indio_dev->info = &vf610_adc_iio_info;
> indio_dev->modes = INDIO_DIRECT_MODE;
> indio_dev->channels = vf610_adc_iio_channels;
> - indio_dev->num_channels = ARRAY_SIZE(vf610_adc_iio_channels);
> + indio_dev->num_channels = (u32)device_get_match_data(dev);
>
> vf610_adc_cfg_init(info);
> vf610_adc_hw_init(info);
> --
> 2.34.1