Re: [PATCH 12/15] dt-bindings: media: addition of stm32mp25 compatible of DCMIPP

[Alain Volmat]

Hi Krzysztof,

On Tue, Oct 08, 2024 at 03:41:59PM +0200, Krzysztof Kozlowski wrote:
> On Tue, Oct 08, 2024 at 01:18:14PM +0200, Alain Volmat wrote:
> > Addition of the stm32mp25 compatible for the DCMIPP.
> 
> "Add"
> See submitting patches.

Commit message corrected in the v2.

> 
> > The stm32mp25 distinguish with the stm32mp13 by the fact that:
> >  - supports also csi inputs in addition to parallel inputs
> >  - requires an addition csi clock to be present
> > 
> > The commit also adds access-controllers, an optional property that
> 
> "Add", see submitting patches.

Here as well.

> 
> > allows a peripheral to refer to one or more domain access controller(s).
> > 
> > Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/media/st,stm32-dcmipp.yaml | 53 +++++++++++++++++++---
> >  1 file changed, 47 insertions(+), 6 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml
> > index 87731f3ce7bd..bda28fef0b78 100644
> > --- a/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml
> > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml
> > @@ -10,9 +10,40 @@ maintainers:
> >    - Hugues Fruchet <hugues.fruchet@xxxxxxxxxxx>
> >    - Alain Volmat <alain.volmat@xxxxxxxxxxx>
> >  
> > +allOf:
> 
> Please put allOf: like in example schema, so after required:.

Done in v2.

> 
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> 
> Best regards,
> Krzysztof
>