Re: [Linux-stm32] [PATCH] irqchip/stm32mp-exti: Use of_property_present() for non-boolean properties

From: Antonio Borneo
Date: Tue Nov 05 2024 - 03:25:39 EST


On Mon, 2024-11-04 at 13:08 -0600, Rob Herring (Arm) wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---
>  drivers/irqchip/irq-stm32mp-exti.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-stm32mp-exti.c b/drivers/irqchip/irq-stm32mp-exti.c
> index 33e0cfdea654..cb83d6cc6113 100644
> --- a/drivers/irqchip/irq-stm32mp-exti.c
> +++ b/drivers/irqchip/irq-stm32mp-exti.c
> @@ -696,8 +696,7 @@ static int stm32mp_exti_probe(struct platform_device *pdev)
>         if (ret)
>                 return ret;
>  
> -       if (of_property_read_bool(np, "interrupts-extended"))
> -               host_data->dt_has_irqs_desc = true;
> +       host_data->dt_has_irqs_desc = of_property_present(np, "interrupts-extended");
>  
>         return 0;
>  }

Reviewed-by: Antonio Borneo <antonio.borneo@xxxxxxxxxxx>

Thanks,
Antonio