Re: [RESEND PATCH] ext4: Annotate struct fname with __counted_by()

From: Thorsten Blum
Date: Tue Nov 05 2024 - 05:17:52 EST


On 5. Nov 2024, at 10:52, Greg KH wrote:
> On Tue, Nov 05, 2024 at 12:42:14AM +0100, Thorsten Blum wrote:
>> Add the __counted_by compiler attribute to the flexible array member
>> name to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
>> CONFIG_FORTIFY_SOURCE.
>>
>> Inline and use struct_size() to calculate the number of bytes to
>> allocate for new_fn and remove the local variable len.
>
> This is two different things, why not do this in two different patches?
>
> thanks,
>
> greg k-h

No particular reason. I'll submit a v2 for the __counted_by() annotation
and a separate patch for struct_size().

I'll keep Jan's Reviewed-by: tag for both.

Thanks,
Thorsten