Re: [PATCH RESEND net-next v4 8/9] net: ip: make ip_mkroute_input/__mkroute_input return drop reasons
From: Paolo Abeni
Date: Tue Nov 05 2024 - 06:26:22 EST
On 10/30/24 02:41, Menglong Dong wrote:
> @@ -1820,7 +1822,8 @@ static int __mkroute_input(struct sk_buff *skb, const struct fib_result *res,
> */
> if (out_dev == in_dev &&
> IN_DEV_PROXY_ARP_PVLAN(in_dev) == 0) {
> - err = -EINVAL;
> + /* what do we name this situation? */
> + reason = SKB_DROP_REASON_ARP_PVLAN_DISABLE;
I don't have a better suggestion :(
Please drop the comment and re-iterate the question in the commit
message after a '---' separator, so we can merge the patch unmodified if
nobody suggests a better one.
Thanks,
Paolo