Re: [RFC PATCH] docs/mm: add VMA locks documentation

From: Lorenzo Stoakes
Date: Tue Nov 05 2024 - 07:24:31 EST


On Mon, Nov 04, 2024 at 05:19:21PM +0200, Mike Rapoport wrote:
> On Mon, Nov 04, 2024 at 02:17:36PM +0000, Lorenzo Stoakes wrote:
> > On Sat, Nov 02, 2024 at 11:00:20AM +0200, Mike Rapoport wrote:
> > > > +
> > > > +The table specifies which write locks must be held to write to the field.
> > > > +
> > > > +.. list-table::
> > > > + :widths: 20 10 22 5 20
> > > > + :header-rows: 1
> > >
> > > And use .. table here as well, e.g
> >
> > Hm this one is a little less clearly worth it because not only will that take me
> > ages but it'll be quite difficult to read in a sensible editor. I can if you
> > insist though?
>
> With spaces it will look just fine in a text editor and IMHO better than
> list-table, but I don't insist.
>
> > > .. table::
> > >
> > > ======== ======== ========================== ================== ==========
> > > Field Config Description Unstable RCU read? Write lock
> > > ======== ======== ========================== ================== ==========
> > > vm_start Inclusive start virtual mmap write,
> > > address of range VMA VMA write
> > > describes
> > >
> > > vm_end Exclusive end virtual mmap write,
> > > address of range VMA VMA write
> > > describes
> > >
> > > vm_rcu vma_lock RCU list head, in union N/A N/A
> > > with vma_start, vma_end.
> > > RCU implementation detail
> > > ======== ======== ========================== ================== ==========
>
> --
> Sincerely yours,
> Mike.

Since it's you Mike I'll do it ;) unless it turns out obviously
awful. Should probably be fine! :)