RE: [Intel-wired-lan] [PATCH iwl-next v1 3/3] ice: support FW Recovery Mode

From: Pucha, HimasekharX Reddy
Date: Tue Nov 05 2024 - 07:54:32 EST


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Konrad Knitter
> Sent: 23 October 2024 15:37
> To: intel-wired-lan@xxxxxxxxxxxxxxxx
> Cc: Keller, Jacob E <jacob.e.keller@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Knitter, Konrad <konrad.knitter@xxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1 3/3] ice: support FW Recovery Mode
>
> Recovery Mode is intended to recover from a fatal failure scenario in which the device is not accessible to the host, meaning the firmware is non-responsive.
>
> The purpose of the Firmware Recovery Mode is to enable software tools to update firmware and/or device configuration so the fatal error can be resolved.
>
> Recovery Mode Firmware supports a limited set of admin commands required for NVM update.
> Recovery Firmware does not support hardware interrupts so a polling mode is used.
>
> The driver will expose only the minimum set of devlink commands required for the recovery of the adapter.
>
> Using an appropriate NVM image, the user can recover the adapter using the devlink flash API.
>
> Prior to 4.20 E810 Adapter Recovery Firmware supports only the update and erase of the "fw.mgmt" component.
>
> E810 Adapter Recovery Firmware doesn't support selected preservation of cards settings or identifiers.
>
> The following command can be used to recover the adapter:
>
> $ devlink dev flash <pci-address> <update-image.bin> component fw.mgmt
> overwrite settings overwrite identifier
>
> Newer FW versions (4.20 or newer) supports update of "fw.undi" and "fw.netlist" components.
>
> $ devlink dev flash <pci-address> <update-image.bin>
>
> Tested on Intel Corporation Ethernet Controller E810-C for SFP FW revision 3.20 and 4.30.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>
> Signed-off-by: Konrad Knitter <konrad.knitter@xxxxxxxxx>
> ---
> .../net/ethernet/intel/ice/devlink/devlink.c | 8 ++-
> .../net/ethernet/intel/ice/ice_adminq_cmd.h | 1 +
> .../net/ethernet/intel/ice/ice_fw_update.c | 14 ++++-
> drivers/net/ethernet/intel/ice/ice_lib.c | 6 +++
> drivers/net/ethernet/intel/ice/ice_lib.h | 1 +
> drivers/net/ethernet/intel/ice/ice_main.c | 53 +++++++++++++++++++
> 6 files changed, 80 insertions(+), 3 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@xxxxxxxxx> (A Contingent worker at Intel)