Re: [PATCH] PCI: epf-mhi: Fix potential NULL dereference in pci_epf_mhi_bind()

From: Krzysztof Wilczyński
Date: Tue Nov 05 2024 - 11:08:46 EST


Hello,

[...]
> > /* Get MMIO base address from Endpoint controller */
> > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mmio");
> > + if (!res) {
> > + dev_err(&pdev->dev, "Failed to get MMIO base address\n");
>
> dev_err(&epf->dev, "Failed to get mmio resource\n");
> or
> dev_err(&epf->dev, "Failed to get \"mmio\" resource\n");
>
> Note: &epf->dev instead of &pdev->dev in order to be consistent with other
> EPF ->bind() functions.
>
> With that, feel free to add:
> Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>

Thank you Niklas!

No need to send a new version of this patch. I will update it on the
branch when applying. Thank you!

Krzysztof