Re: [PATCH 2/3] i2c: pxa: Add check for clk_enable() and clk_prepare_enable()

[Jiasheng Jiang]

Hi Andi,

On Tue, Nov 5, 2024 at 9:13 AM Andi Shyti <andi.shyti@xxxxxxxxxx> wrote:

> > Add check for the return values of clk_enable() and clk_prepare_enable()
> > in order to catch the potential exceptions.
> >
> > Fixes: e7d48fa2b5fb ("[I2C] pxa: provide late suspend and early resume hooks")
> > Fixes: c3cef3f3c07b ("[ARM] pxa: update pxa i2c driver to use clk support")
>
> I don't think we need the fixes tag here and nowhere else in this
> series.
>
> > Signed-off-by: Jiasheng Jiang <jiashengjiangcool@xxxxxxxxx>
> > ---
> >  drivers/i2c/busses/i2c-pxa.c | 14 ++++++++++++--
> >  1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
> > index 4d76e71cdd4b..1118a7f5c6bf 100644
> > --- a/drivers/i2c/busses/i2c-pxa.c
> > +++ b/drivers/i2c/busses/i2c-pxa.c
> > @@ -1503,7 +1503,11 @@ static int i2c_pxa_probe(struct platform_device *dev)
> >                               i2c->adap.name);
> >       }
> >
> > -     clk_prepare_enable(i2c->clk);
> > +     ret = clk_prepare_enable(i2c->clk);
> > +     if (ret) {
> > +             dev_err(&dev->dev, "failed to enable clock: %d\n", ret);
>
> please use dev_err_probe here.

Thanks, I have submitted a v2 series without the above problems.

-Jiasheng