Re: [PATCH net-next v3 2/2] bnxt_en: ethtool: Support unset l4proto on ip4/ip6 ntuple rules

[Michael Chan]

On Mon, Nov 4, 2024 at 8:13 PM Daniel Xu <dxu@xxxxxxxxx> wrote:
>
> Previously, trying to insert an ip4/ip6 ntuple rule with an unset
> l4proto would get rejected with -EOPNOTSUPP. For example, the following
> would fail:
>
>     ethtool -N eth0 flow-type ip6 dst-ip $IP6 context 1
>
> The reason was that all the l4proto validation was being run despite the
> l4proto mask being set to 0x0. Fix by respecting the mask on l4proto and
> treating a mask of 0x0 as wildcard l4proto.
>
> Signed-off-by: Daniel Xu <dxu@xxxxxxxxx>

I just realized that we don't allow l4_proto 6 and 17 for TCP and UDP.
It's been this way since the feature was added.  I can add it later to
make it more complete.  Thanks.

Reviewed-by: Michael Chan <michael.chan@xxxxxxxxxxxx>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature