Re: [PATCH v4 11/20] ACPI: platform_profile: Add choices attribute for class interface
From: kernel test robot
Date: Tue Nov 05 2024 - 20:10:10 EST
Hi Mario,
kernel test robot noticed the following build warnings:
[auto build test WARNING on d68cb6023356af3bd3193983ad4ec03954a0b3e2]
url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/ACPI-platform-profile-Add-a-name-member-to-handlers/20241105-233922
base: d68cb6023356af3bd3193983ad4ec03954a0b3e2
patch link: https://lore.kernel.org/r/20241105153316.378-12-mario.limonciello%40amd.com
patch subject: [PATCH v4 11/20] ACPI: platform_profile: Add choices attribute for class interface
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20241106/202411060835.GlMKVSsy-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241106/202411060835.GlMKVSsy-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411060835.GlMKVSsy-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/acpi/platform_profile.c:55: warning: Function parameter or struct member 'choices' not described in '_get_class_choices'
vim +55 drivers/acpi/platform_profile.c
48
49 /**
50 * _get_class_choices - Get the available profile choices for a class device
51 * @dev: The class device
52 * Return: The available profile choices
53 */
54 static int _get_class_choices(struct device *dev, unsigned long *choices)
> 55 {
56 struct platform_profile_handler *handler;
57 int i;
58
59 scoped_cond_guard(mutex_intr, return -ERESTARTSYS, &profile_lock) {
60 handler = dev_get_drvdata(dev);
61 for_each_set_bit(i, handler->choices, PLATFORM_PROFILE_LAST)
62 *choices |= BIT(i);
63 }
64
65 return 0;
66 }
67
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki