Re: [PATCH v4 5/5] tools/memory-model: Distinguish between syntactic and semantic tags

From: Jonas Oberhauser
Date: Wed Nov 06 2024 - 05:28:56 EST




Am 11/5/2024 um 9:21 PM schrieb Paul E. McKenney:
On Wed, Oct 30, 2024 at 07:34:45AM -0700, Boqun Feng wrote:
On Wed, Oct 30, 2024 at 12:38:26PM +0100, Jonas Oberhauser wrote:


Am 10/30/2024 um 12:41 AM schrieb Paul E. McKenney:
On Mon, Oct 28, 2024 at 05:15:46PM -0700, Boqun Feng wrote:
On Mon, Sep 30, 2024 at 12:57:10PM +0200, Jonas Oberhauser wrote:
Not all tags that are always there syntactically also provide semantic
membership in the corresponding set. For example, an 'acquire tag on a

Maybe:

Not all annotated accesses provide the same semantic as their syntactic
tags...

?

Jonas, are you OK with this change? If so, I can apply it on my next
rebase.


I'm ok with an extra s after semantics and a minor rephrase:

Not all annotated accesses provide the semantics their syntactic
tags would imply

What do you think @Boqun ?

Yes, of course! This looks good to me.

Please see below for what I currently have. If there are no objections
in a day or so, I will set up these five commits for the upcoming v6.13
merge window.

The additional bit pointed out by Boqun [1] can be addressed by a
separate commit.

Thanx, Paul

[1] https://lore.kernel.org/all/ZyAmlh5GDBsqY0sZ@Boquns-Mac-mini.local/

I'm confused, did I forget to add the fix to the capitalization issue discovered by Boqun to the fixed commit? I vividly remember typing git commit add ...


jonas