Re: [PATCH tty-next v3 3/6] serial: 8250: Split out rx stop/start code into helpers

[Petr Mladek]

On Fri 2024-10-25 13:03:25, John Ogness wrote:
> The rx stop/start callbacks also disable/enable interrupts. This
> is not acceptable for the console write callback since it must
> manage all interrupt disabling/enabling.
> 
> Move the interrupt disabling/enabling/masking into helper
> functions so that the console write callback can make use of
> the appropriate parts in a follow-up commit.
> 
> This is essentially refactoring and should cause no functional
> change.
> 
> Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx>

The changes look reasonable and do what described:

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr