Re: [PATCH v3 3/6] dt-bindings: clock: qcom: Add CAMCC clocks for QCS8300

From: Krzysztof Kozlowski
Date: Wed Nov 06 2024 - 07:00:08 EST


On Wed, Nov 06, 2024 at 03:21:58PM +0530, Imran Shaik wrote:
+
> +#include "qcom,sa8775p-camcc.h"
> +
> +/* QCS8300 introduces below new clocks compared to SA8775P */
> +
> +/* CAM_CC clocks */
> +#define CAM_CC_TITAN_TOP_ACCU_SHIFT_CLK 86

I really wonder what you are going to do when sa8775p grows by one clock
and will get ID of 86 :) (and before you say sa8775p will use 87, let me
just clarify it will have to get 86 because no gaps would be
accepted in existing header)

But that's not my problem:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof