Re: [Intel-wired-lan] [PATCH v4 net-next 1/4] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()

[Avigail Dahan]

On 26/10/2024 7:12, Yue Haibing wrote:
> igc_xdp_run_prog() converts customed xdp action to a negative error code
> with the sk_buff pointer type which be checked with IS_ERR in
> igc_clean_rx_irq(). Remove this error pointer handing instead use plain
> int return value to fix this smatch warnings:
>
> drivers/net/ethernet/intel/igc/igc_main.c:2533
>   igc_xdp_run_prog() warn: passing zero to 'ERR_PTR'
>
> Fixes: 26575105d6ed ("igc: Add initial XDP support")
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>
> Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>
> Signed-off-by: Yue Haibing <yuehaibing@xxxxxxxxxx>
> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 20 +++++++-------------
>   1 file changed, 7 insertions(+), 13 deletions(-)
Tested-by: Avigail Dahan <avigailx.dahan@xxxxxxxxx>