Re: [PATCH v3 1/2] hwmon: (ina226) Add support for SY24655

From: Guenter Roeck
Date: Wed Nov 06 2024 - 10:40:01 EST


On 11/6/24 07:05, wenliang wrote:
SY24655: Support for current and voltage detection as well as
power calculation.

Signed-off-by: wenliang <wenliang202407@xxxxxxx>
---

@@ -668,6 +731,11 @@ static umode_t ina2xx_is_visible(const void *_data, enum hwmon_sensor_types type
if (has_alerts)
return 0444;
break;
+ case hwmon_power_average:
+ if (has_power_average)
+ return 0444;
+ break;
+ return 0444;

That is quite obviously wrong. Again, I'll fix it up myself
while applying the patch.

Guenter