Re: [PATCH v4 5/7] hwmon: (pmbus/core) clear faults after setting smbalert mask

[Guenter Roeck]

On Tue, Nov 05, 2024 at 06:58:42PM +0100, Jerome Brunet wrote:
> pmbus_write_smbalert_mask() ignores the errors if the chip can't set
> smbalert mask the standard way. It is not necessarily a problem for the irq
> support if the chip is otherwise properly setup but it may leave an
> uncleared fault behind.
> 
> pmbus_core will pick the fault on the next register_check(). The register
> check will fails regardless of the actual register support by the chip.
> 
> This leads to missing attributes or debugfs entries for chips that should
> provide them.
> 
> We cannot rely on register_check() as PMBUS_SMBALERT_MASK may be read-only.
> 
> Unconditionally clear the page fault after setting PMBUS_SMBALERT_MASK to
> avoid the problem.
> 
> Suggested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Fixes: 221819ca4c36 ("hwmon: (pmbus/core) Add interrupt support")
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>

Applied.

Thanks,
Guenter