Re: [PATCHv2 net-next] net: sfc: use ethtool string helpers

From: Edward Cree
Date: Wed Nov 06 2024 - 15:14:25 EST


On 05/11/2024 23:18, Rosen Penev wrote:
> The latter is the preferred way to copy ethtool strings.
>
> Avoids manually incrementing the pointer. Cleans up the code quite well.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>

Acked-by: Edward Cree <ecree.xilinx@xxxxxxxxx>

I was initially curious why we still needed the 'n_stats++;' bits,
for the record it's for .get_sset_count(). (If you end up needing
to respin for any reason, perhaps make that explicit in the commit
message.)