Re: [PATCH v3] mm: count zeromap read and set for swapout and swapin

[Andrew Morton]

On Thu, 7 Nov 2024 10:00:47 +1300 Barry Song <21cnbao@xxxxxxxxx> wrote:

> On Thu, Nov 7, 2024 at 9:42 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Thu, 7 Nov 2024 09:01:14 +1300 Barry Song <21cnbao@xxxxxxxxx> wrote:
> >
> > > Oops, it seems that it depends on Kanchana's 'mm: change count_objcg_event() to
> > > count_objcg_events() for batch event updates,' which also isn't present in 6.12.
> > >
> > > Otherwise, it won't build, as reported here:
> > > https://lore.kernel.org/linux-mm/CAGsJ_4whD31+Lk0m2uq-o=ygvkRsw1uXcPeqxBONV-RUXkeEzg@xxxxxxxxxxxxxx/
> >
> > argh.
> >
> 
> Apologies for the inconvenience.
> 
> > > Hi Andrew,
> > > What’s the best approach here? Should we include Kanchana's patch that extends
> > > the nr argument for count_objcg_events() in 6.12-rc as well?
> >
> > Let's do the right thing here.  I'll drop this patch from mm-hotfixes.
> > Please send a v4 against Linus mainline fairly soon then I'll redo
> > Kanchana's series around that.
> 
> Alright. The question is whether we should integrate Kanchana's 'mm:
> change count_objcg_event() to count_objcg_events() for batch event
> updates' into 'mm: count zeromap read and set for swapout and swapin,'
> or keep it as a separate patch as patch 1/2?
> 
> I guess integration would be better, as hotfixes may not be ideal for a patch
> series?

I don't fully understand what you're asking here.

I'm suggesting that you prepare a minimal patch that fixes the bug in
Linus's kernel.  Then we figure out what to do with Kanchana's 6.13-rc1
material after the bugfix is sorted out.