Re: [PATCH v2 2/2] net: arc: rockchip: fix emac mdio node support

From: Andrew Lunn
Date: Wed Nov 06 2024 - 22:06:00 EST


On Wed, Nov 06, 2024 at 05:50:02PM -0800, Jakub Kicinski wrote:
> On Mon, 4 Nov 2024 21:01:39 +0800 Andy Yan wrote:
> > From: Johan Jonker <jbx6244@xxxxxxxxx>
> >
> > The binding emac_rockchip.txt is converted to YAML.
> > Changed against the original binding is an added MDIO subnode.
> > This make the driver failed to find the PHY, and given the 'mdio
> > has invalid PHY address' it is probably looking in the wrong node.
> > Fix emac_mdio.c so that it can handle both old and new
> > device trees.
>
> Andrew, looks good?

The MDIO patch looks correct. I cannot say anything about the DMA
mapping.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew