RE: [PATCH net-next 0/5] Add more feautues for ENETC v4 - round 1

[Wei Fang]

> -----Original Message-----
> From: Hariprasad Kelam <hkelam@xxxxxxxxxxx>
> Sent: 2024年11月7日 17:12
> To: Wei Fang <wei.fang@xxxxxxx>
> Cc: Claudiu Manoil <claudiu.manoil@xxxxxxx>; Vladimir Oltean
> <vladimir.oltean@xxxxxxx>; Clark Wang <xiaoning.wang@xxxxxxx>;
> andrew+netdev@xxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next 0/5] Add more feautues for ENETC v4 - round 1
> 
> On 2024-11-07 at 09:08:12, Wei Fang (wei.fang@xxxxxxx) wrote:
> > Compared to ENETC v1 (LS1028A), ENETC v4 (i.MX95) adds more features,
> > and some features are configured completely differently from v1. In
> > order to more fully support ENETC v4, these features will be added
> > through several rounds of patch sets. This round adds these features,
> > such as Tx and Rx checksum offload, increase maximum chained Tx BD
> > number and Large send offload (LSO).
> >
> > Wei Fang (5):
> >   net: enetc: add Rx checksum offload for i.MX95 ENETC
> >   net: enetc: add Tx checksum offload for i.MX95 ENETC
> >   net: enetc: update max chained Tx BD number for i.MX95 ENETC
> >   net: enetc: add LSO support for i.MX95 ENETC PF
> >   net: enetc: add UDP segmentation offload support
> >
> 
> Can you refactor the patches in a way that "ndev->hw_features" set in
> corresponding patch.
> 
> 
> Setting NETIF_F_HW_CSUM in "net: enetc: add UDP segmentation offload
> support" does not look good to me.
> 

Sorry, I don't quite understand. I only set NETIF_F_GSO_UDP_L4 in the patch.
NETIF_F_HW_CSUM was already set before this patch set.