Re: [PATCH 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family

[Joey Lu]

Dear Andrew,

Thank you for your reply.

Andrew Lunn 於 11/7/2024 2:23 AM 寫道:
> > +struct nvt_priv_data {
> > +	struct platform_device *pdev;
> > +	int id;
> > +	struct regmap *regmap;
> > +	phy_interface_t phy_mode;
> phy_mode does not seem to be used outside of nuvoton_gmac_setup(). In
> fact nothing in nvt_priv_data is used outside of
> nuvoton_gmac_setup. So it looks like you can remove it.
I will remove it.
> > +	if (of_property_read_u32(dev->of_node, "tx_delay", &tx_delay)) {
> > +		dev_info(dev, "Set TX delay(0x0).\n");
> > +		tx_delay = 0x0;
> > +	} else {
> > +		dev_info(dev, "Set TX delay(0x%x).\n", tx_delay);
> Please don't spam the logs. dev_dbg(), or no message at all.
>
> 	Andrew
I will fix it.

Thanks!

BR,

Joey