Re: [PATCH] arm64: dts: mediatek: mt8186: Move wakeup to MTU3 to get working suspend

[AngeloGioacchino Del Regno]

Il 06/11/24 22:01, Nícolas F. R. A. Prado ha scritto:
> The current DT has the wakeup-source and mediatek,syscon-wakeup
> properties in the XHCI nodes, which configures USB wakeup after powering
> down the XHCI hardware block. However, since the XHCI controller is
> behind an MTU3 (USB3 DRD controller), the MTU3 only gets powered down
> after USB wakeup has been configured, causing the system to detect a
> wakeup, and results in broken suspend support as the system resumes
> immediately.
>
> Move the wakeup properties to the MTU3 nodes so that USB wakeup is only
> enabled after the MTU3 has powered down.
>
> With this change in place, it is possible to suspend and resume, and
> also to wakeup through USB, as tested on the Google Steelix (Lenovo 300e
> Yoga Chromebook Gen 4).
>
> Fixes: f6c3e61c5486 ("arm64: dts: mediatek: mt8186: Add MTU3 nodes")
> Reported-by: Wojciech Macek <wmacek@xxxxxxxxxx>
> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>