Re: [PATCH 2/3] phy: samsung-ufs: support exynosauto ufs phy driver

[Krzysztof Kozlowski]

On Thu, Nov 07, 2024 at 03:35:23PM +0530, Alim Akhtar wrote:
> Hello Sowon
> 
> > -----Original Message-----
> > From: Sowon Na <sowon.na@xxxxxxxxxxx>
> > Sent: Thursday, November 7, 2024 9:45 AM
> > To: robh@xxxxxxxxxx; krzk@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
> > vkoul@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; kishon@xxxxxxxxxx
> > Cc: krzk+dt@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > devicetree@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx;
> > sowon.na@xxxxxxxxxxx
> > Subject: [PATCH 2/3] phy: samsung-ufs: support exynosauto ufs phy driver
> > 
> s/exynosauto/ exynosautov920
> let's be specific as we have v9 variant as well.
> 
> > Support phy-exynosautov920-ufs driver for ExynosAutov920 series SoCs,
> > using "samsung,exynosautov920-ufs-phy" compatible.
> > 
> s/ ExynosAutov920/ exynosautov920
> May be just: Add support for exynosautov920 ufs phy driver
> 
> using "samsung,exynosautov920-ufs-phy" compatible is obvious
> 
> > Signed-off-by: Sowon Na <sowon.na@xxxxxxxxxxx>
> > ---
> >  drivers/phy/samsung/Makefile                 |   1 +
> >  drivers/phy/samsung/phy-exynosautov920-ufs.c | 159
> > +++++++++++++++++++
> >  drivers/phy/samsung/phy-samsung-ufs.c        |   9 +-
> >  drivers/phy/samsung/phy-samsung-ufs.h        |   4 +
> >  4 files changed, 170 insertions(+), 3 deletions(-)  create mode 100644
> > drivers/phy/samsung/phy-exynosautov920-ufs.c
> > 
> > diff --git a/drivers/phy/samsung/Makefile b/drivers/phy/samsung/Makefile
> > index fea1f96d0e43..342682638a87 100644
> > --- a/drivers/phy/samsung/Makefile
> > +++ b/drivers/phy/samsung/Makefile
> > @@ -7,6 +7,7 @@ phy-exynos-ufs-y			+= phy-gs101-ufs.o
> >  phy-exynos-ufs-y			+= phy-samsung-ufs.o
> >  phy-exynos-ufs-y			+= phy-exynos7-ufs.o
> >  phy-exynos-ufs-y			+= phy-exynosautov9-ufs.o
> > +phy-exynos-ufs-y			+= phy-exynosautov920-ufs.o
> >  phy-exynos-ufs-y			+= phy-fsd-ufs.o
> >  obj-$(CONFIG_PHY_SAMSUNG_USB2)		+= phy-exynos-
> > usb2.o
> >  phy-exynos-usb2-y			+= phy-samsung-usb2.o
> > diff --git a/drivers/phy/samsung/phy-exynosautov920-ufs.c
> > b/drivers/phy/samsung/phy-exynosautov920-ufs.c
> > new file mode 100644
> > index 000000000000..8f4a94e13781
> > --- /dev/null
> > +++ b/drivers/phy/samsung/phy-exynosautov920-ufs.c
> > @@ -0,0 +1,159 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * UFS PHY driver data for Samsung EXYNOSAUTO v920 SoC
> Let be consistent with the naming, may be EXYNOSAUTOV920

We keep everywhere non-capitalized name, so ExynosAuto

Best regards,
Krzysztof