Re: [PATCH] printk: Fix signed integer overflow when defining LOG_BUF_LEN_MAX
From: Kuan-Wei Chiu
Date: Thu Nov 07 2024 - 07:43:04 EST
On Tue, Oct 01, 2024 at 01:27:03PM +0200, Petr Mladek wrote:
> On Sat 2024-09-28 19:36:08, Kuan-Wei Chiu wrote:
> > Shifting 1 << 31 on a 32-bit int causes signed integer overflow, which
> > leads to undefined behavior. To prevent this, cast 1 to u32 before
> > performing the shift, ensuring well-defined behavior.
> >
> > This change explicitly avoids any potential overflow by ensuring that
> > the shift occurs on an unsigned 32-bit integer.
> >
> > Signed-off-by: Kuan-Wei Chiu <visitorckw@xxxxxxxxx>
>
> Looks good to me.
>
> Acked-by: Petr Mladek <pmladek@xxxxxxxx>
>
It has been over a month since I submitted this patch, and with only
1-2 weeks left until the next merge window opens, I still haven't seen
it included in linux-next. I'd like to check on the current status of
this patch.
Regards,
Kuan-Wei