Re: [PATCH v2 1/2] tracing: Add task_prctl_unknown tracepoint

From: Marco Elver
Date: Thu Nov 07 2024 - 10:47:46 EST


On Thu, 7 Nov 2024 at 16:34, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
...
> > + TP_PROTO(struct task_struct *task, int option, unsigned long arg2, unsigned long arg3,
> > + unsigned long arg4, unsigned long arg5),
> > +
> > + TP_ARGS(task, option, arg2, arg3, arg4, arg5),
> > +
> > + TP_STRUCT__entry(
> > + __string( comm, task->comm )
>
> The question is, do we really need comm? From your example, it's redundant:
>
> test-484 [000] ..... 631.748104: task_prctl_unknown: comm=test option=1234 arg2=101 arg3=102 arg4=103 arg5=104
> ^^^^ ^^^^

Ack, let's remove it. I will also remove the "task" argument.