Re: [PATCH v2] USB: serial: ftdi_sio: Fix atomicity violation in get_serial_info()

[Johan Hovold]

On Thu, Nov 07, 2024 at 07:35:34PM +0800, Qiu-ji Chen wrote:
> Our static checker found a bug where set_serial_info() uses a mutex, but
> get_serial_info() does not. Fortunately, the impact of this is relatively
> minor. It doesn't cause a crash or any other serious issues. However, if a
> race condition occurs between set_serial_info() and get_serial_info(),
> there is a chance that the data returned by get_serial_info() will be
> inconsistent.
> 
> Signed-off-by: Qiu-ji Chen <chenqiuji666@xxxxxxxxx>
> Fixes: 3ae36bed3a93 ("fdti_sio: switch to ->[sg]et_serial()")
> ---
> Similar issues have been submitted or confirmed: 
> https://lore.kernel.org/all/20241002125845.785464707@xxxxxxxxxxxxxxxxxxx/ 
> https://lore.kernel.org/all/20241106095819.15194-1-chenqiuji666@xxxxxxxxx/
> ---
> V2:
> Revised the description, placed the reference link below "---".
> Used the correct patch prefix.
> Thanks Johan Hovold for helpful suggestion.

Applied for -next, thanks.

Johan