Re: [PATCH v2 1/1] x86/fred: Clear WFE in missing-ENDBRANCH #CPs
From: Dave Hansen
Date: Thu Nov 07 2024 - 13:58:07 EST
On 11/7/24 10:54, Xin Li wrote:
> +static void ibt_clear_fred_wfe(struct pt_regs *regs)
> +{
> + regs->fred_cs.wfe = 0;
> +}
Also, just looking at this, we have obviously FRED-specific code without
any FRED checks. Now I know we asked you to remove those checks, but
this does need commenting or at least a changelog sentence on why this
incorrect-looking code is still OK.