Re: [PATCH] cxl: Rename ACPI_CEDT_CFMWS_RESTRICT_TYPE2/TYPE3
From: Dan Williams
Date: Thu Nov 07 2024 - 16:35:37 EST
Alison Schofield wrote:
[..]
> > I think so too. However, I prefer to keep this patch just mechanic
> > renaming and do these changes in another patch. Do you agree?
> >
>
> I don't know. I was just questioning where and how far the naming scheme
> needs to change.
>
> Maybe Jonathan, as the Suggested-by, can chime in and move this ahead.
I feel like we are going to be living with the ghosts of the original
"Type2 / Type3" naming problem for the rest of the subsystem's lifespan
especially since they were encoded in the ABI and ABI is forever.
I am not opposed to this localized rename in drivers/cxl/acpi.c on
principal, but in terms of incremental value relative to the thrash, it's
questionable.
For example changes to include/acpi/actbl1.h need to be chased through
ACPICA, at which point is this rename really worth it?