Re: [PATCH md-6.13] md: remove bitmap file support
From: Song Liu
Date: Thu Nov 07 2024 - 20:29:20 EST
On Thu, Nov 7, 2024 at 5:03 PM Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> wrote:
>
> Hi,
>
> 在 2024/11/08 7:41, Song Liu 写道:
> > On Thu, Nov 7, 2024 at 5:02 AM Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> wrote:
> >>
> >> From: Yu Kuai <yukuai3@xxxxxxxxxx>
> >>
> >> The bitmap file has been marked as deprecated for more than a year now,
> >> let's remove it, and we don't need to care about this case in the new
> >> bitmap.
> >>
> >> Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>
> >
> > What happens when an old array with bitmap file boots into a kernel
> > without bitmap file support?
>
> If mdadm is used with bitmap file support, then kenel will just ignore
> the bitmap, the same as none bitmap. Perhaps it's better to leave a
> error message?
Yes, we should print some error message before assembling the array.
> And if mdadm is updated, reassemble will fail.
I think we should ship this with 6.14 (not 6.13), so that we have
more time testing different combinations of old/new mdadm
and kernel. WDYT?
Thanks,
Song