Re: [PATCH 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC

[Joey Lu]

Conor Dooley 於 11/8/2024 1:09 AM 寫道:
> On Thu, Nov 07, 2024 at 06:15:51PM +0800, Joey Lu wrote:
> > Conor Dooley 於 11/6/2024 11:44 PM 寫道:
> > > On Wed, Nov 06, 2024 at 07:19:28PM +0800, Joey Lu wrote:
> > > > +  nuvoton,sys:
> > > > +    $ref: /schemas/types.yaml#/definitions/phandle
> > > > +    description: phandle to access GCR (Global Control Register) registers.
> > > Why do you need a phandle to this? You appear to have multiple dwmacs on
> > > your device if the example is anything to go by, how come you don't need
> > > to access different portions of this depending on which dwmac instance
> > > you are?
> > On our platform, a system register is required to specify the TX/RX clock
> > path delay control, switch modes between RMII and RGMII, and configure other
> > related settings.
> > > > +  resets:
> > > > +    maxItems: 1
> > > > +
> > > > +  reset-names:
> > > > +    items:
> > > > +      - const: stmmaceth
> > > > +
> > > > +  mac-id:
> > > > +    maxItems: 1
> > > > +    description:
> > > > +      The interface of MAC.
> > > A vendor prefix is required for custom properties, but I don't think you
> > > need this and actually it is a bandaid for some other information you're
> > > missing. Probably related to your nuvoton,sys property only being a
> > > phandle with no arguments.
> > This property will be removed.
> I'm almost certain you can't just remove this property, because you need
> it to tell which portion of the GCR is applicable to the dwmac instance
> in question. Instead, you need to ad an argument to your phandle. The
> starfive dwmac binding/driver has an example of what you can do.

Yes, I will use this method instead.🙂

mac-id and tx/rx-delay will be arguments of syscon.

Thanks!