Re: [PATCH v9 1/5] perf/marvell: Refactor to extract platform data - no functional change
From: Gowthami Thiagarajan
Date: Thu Nov 07 2024 - 23:02:23 EST
Hi Will,
From: Will Deacon <will@xxxxxxxxxx>
Sent: Thursday, October 24, 2024 5:39 PM
To: Gowthami Thiagarajan <gthiagarajan@xxxxxxxxxxx>
Cc: mark.rutland@xxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Bharat Bhushan <bbhushan2@xxxxxxxxxxx>; George Cherian <gcherian@xxxxxxxxxxx>; Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; jonathan.cameron@xxxxxxxxxx
Subject: [EXTERNAL] Re: [PATCH v9 1/5] perf/marvell: Refactor to extract platform data - no functional changeOn Wed, Oct 16, 2024 at 01: 31: 49PM +0530, Gowthami Thiagarajan wrote: > This commit introduces a refactor to the Marvell DDR pmu driver, > specifically targeting the extraction of platform data > (referred to as "pdata") from the existing
On Wed, Oct 16, 2024 at 01:31:49PM +0530, Gowthami Thiagarajan wrote:
> This commit introduces a refactor to the Marvell DDR pmu driver,
> specifically targeting the extraction of platform data
> (referred to as "pdata") from the existing driver. The purpose of
> this refactor is to prepare for the upcoming support of the next
> version of the Performance Monitoring Unit (PMU) in this
> driver.
>
> No functional changes are introduced in this refactor. Its sole
> purpose is to improve code organization and pave the way for
> future enhancements to the driver.
>
> Signed-off-by: Gowthami Thiagarajan <mailto:gthiagarajan@xxxxxxxxxxx>
> ---
> drivers/perf/marvell_cn10k_ddr_pmu.c | 160 +++++++++++++++++++--------
> 1 file changed, 112 insertions(+), 48 deletions(-)
Please read the "Describe your changes" section of
Documentation/process/submitting-patches.rst. Specifically, we're
supposed to use the imperative mood and avoid saying "This patch" (This
commit).
Your other commit messages have the same problems.
Will update the commit messages.
Thanks,
Gowthami
Will