Re: [PATCH 5.4 000/461] 5.4.285-rc2 review

[Greg Kroah-Hartman]

On Thu, Nov 07, 2024 at 08:39:39AM -0800, Florian Fainelli wrote:
> 
> 
> On 11/6/2024 10:47 PM, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.4.285 release.
> > There are 461 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Sat, 09 Nov 2024 06:32:59 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.285-rc2.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> 
> On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
> BMIPS_GENERIC:
> 
> Tested-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> 
> There are however new build warnings, on 32-bit:
> 
> In file included from ./include/linux/mm.h:29,
>                  from ./include/linux/pagemap.h:8,
>                  from ./include/linux/buffer_head.h:14,
>                  from fs/udf/udfdecl.h:12,
>                  from fs/udf/inode.c:32:
> fs/udf/inode.c: In function 'udf_current_aext':
> ./include/linux/overflow.h:61:22: warning: comparison of distinct pointer
> types lacks a cast
>    61 |         (void) (&__a == __d);                   \
>       |                      ^~
> fs/udf/inode.c:2202:21: note: in expansion of macro 'check_add_overflow'
>  2202 |                 if (check_add_overflow(sizeof(struct allocExtDesc),
>       |                     ^~~~~~~~~~~~~~~~~~
> 
> 
> On 64-bit:
> 
> fs/udf/inode.c: In function 'udf_current_aext':
> ./include/linux/overflow.h:60:15: warning: comparison of distinct pointer
> types lacks a cast
>   (void) (&__a == &__b);   \
>                ^~
> fs/udf/inode.c:2202:7: note: in expansion of macro 'check_add_overflow'
>    if (check_add_overflow(sizeof(struct allocExtDesc),
>        ^~~~~~~~~~~~~~~~~~
> ./include/linux/overflow.h:61:15: warning: comparison of distinct pointer
> types lacks a cast
>   (void) (&__a == __d);   \
>                ^~
> fs/udf/inode.c:2202:7: note: in expansion of macro 'check_add_overflow'
>    if (check_add_overflow(sizeof(struct allocExtDesc),
>        ^~~~~~~~~~~~~~~~~~
> 
> In file included from ./include/linux/mm.h:29,
>                  from ./include/linux/pagemap.h:8,
>                  from ./include/linux/buffer_head.h:14,
>                  from fs/udf/udfdecl.h:12,
>                  from fs/udf/super.c:41:
> fs/udf/super.c: In function 'udf_fill_partdesc_info':
> ./include/linux/overflow.h:60:15: warning: comparison of distinct pointer
> types lacks a cast
>   (void) (&__a == &__b);   \
>                ^~
> fs/udf/super.c:1162:7: note: in expansion of macro 'check_add_overflow'
>    if (check_add_overflow(map->s_partition_len,
>        ^~~~~~~~~~~~~~~~~~

Yes, this is due to commit d219d2a9a92e ("overflow: Allow mixed type
arguments") not being backported to 5.4 and 5.10.y trees.  If people
want to see these warnings removed, perhaps someone can provide a
working backport of this commit :)

thanks,

greg k-h