Re: [PATCH v4 3/6] arm64: Add Blaize BLZP1600 SoC family

From: Krzysztof Kozlowski
Date: Fri Nov 08 2024 - 05:58:26 EST


On 08/11/2024 11:31, Niko Pasaloukos wrote:
> Add ARCH_BLAIZE_BLZP1600 SoC family to the arm64 architecture.
>
> Resolves: PESW-2604
> Checkpatch: ignore

NAK.

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.

>
> Reviewed-by: James Cowgill <james.cowgill@xxxxxxxxxx>
> Reviewed-by: Matt Redfearn <matt.redfearn@xxxxxxxxxx>
> Reviewed-by: Neil Jones <neil.jones@xxxxxxxxxx>

Are these real reviews?

Best regards,
Krzysztof