Re: [PATCH 3/3] tty: serial: atmel: make it selectable for ARCH_LAN969X

From: Nicolas Ferre
Date: Fri Nov 08 2024 - 08:53:21 EST


On 08/11/2024 at 14:40, Robert Marko wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On Fri, Nov 8, 2024 at 2:25 PM Nicolas Ferre
<nicolas.ferre@xxxxxxxxxxxxx> wrote:

On 08/11/2024 at 12:22, Robert Marko wrote:

A little commit message would be better.

Hi Nicolas, I basically reused the same commit description as for MFD
and else as all of the changes are
basically the same.

Ok, I have certainly deleted it while replying. That's fine then.

Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>
---
drivers/tty/serial/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 45f0f779fbf9..e6cf20b845f1 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -128,7 +128,7 @@ config SERIAL_SB1250_DUART_CONSOLE
config SERIAL_ATMEL
bool "AT91 on-chip serial port support"
depends on COMMON_CLK
- depends on ARCH_AT91 || COMPILE_TEST
+ depends on ARCH_AT91 || ARCH_LAN969X ||COMPILE_TEST

Checkpatch.pl reports some "DOS line endings", you might need to fix this.

Hm, I ran checkpatch before sending in verbose mode and I dont see
such a warning,
my Sublime text is also set to Unix endings, I also just checked with
cat -e and I dont see
any DOS endings.

Ok, indeed. Probably my email client then. Sorry for the noise.

Regards,
Nicolas


select SERIAL_CORE
select SERIAL_MCTRL_GPIO if GPIOLIB
select MFD_AT91_USART
--
2.47.0


Once fixed, you can add my:
Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>

Thanks, best regards,
Nicolas



--
Robert Marko
Staff Embedded Linux Engineer
Sartura d.d.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@xxxxxxxxxx
Web: www.sartura.hr