Re: [PATCH] arm64: dts: qcom: sa8775p: Use valid node names for GPI DMAs

[Dmitry Baryshkov]

On Thu, Nov 07, 2024 at 10:15:32PM +0100, Konrad Dybcio wrote:
> On 7.11.2024 10:14 PM, Konrad Dybcio wrote:
> > From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > 
> > As pointed out by Intel's robot, the node name doesn't adhere to
> > dt-bindings.
> > 
> > Fix errors like this one:
> > 
> > qcs9100-ride.dtb: qcom,gpi-dma@800000: $nodename:0: 'qcom,gpi-dma@800000' does not match '^dma-controller(@.*)?$'
> > 
> > Fixes: 34d17ccb5db8 ("arm64: dts: qcom: sa8775p: Add GPI configuration")
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202411080206.vFLRjIBZ-lkp@xxxxxxxxx/
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> > index 9f315a51a7c14cd4116ec5a66a60285361d343f1..ebfa049515c63a0f1a333315dd370e6f78501129 100644
> > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> > @@ -854,7 +854,7 @@ ipcc: mailbox@408000 {
> >  			#mbox-cells = <2>;
> >  		};
> >  
> > -		gpi_dma2: qcom,gpi-dma@800000  {
> > +		gpi_dma2: dma-controller@800000  {
> >  			compatible = "qcom,sm6350-gpi-dma";
> 
> Now that I sent it, this also doesn't look right..

For the node renames:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>


-- 
With best wishes
Dmitry