Re: [PATCH v4 5/5] tools/memory-model: Distinguish between syntactic and semantic tags
From: Paul E. McKenney
Date: Fri Nov 08 2024 - 13:35:30 EST
On Fri, Nov 08, 2024 at 12:07:43PM +0100, Jonas Oberhauser wrote:
>
>
> Am 11/8/2024 um 11:12 AM schrieb Akira Yokosawa:
> > On Fri, 8 Nov 2024 10:10:48 +0100, Jonas Oberhauser wrote:
> > > I hadn't done that before (because I thought I should not add other people's tags
> > > especially if they hadn't reviewed that specific revision), so we may be missing
> > > *a lot* of reviewed-by...
> > >
> >
> > Section "Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:"
> > of Documentation/process/submitting-patches.rst has this paragraph:
> >
> > Both Tested-by and Reviewed-by tags, once received on mailing list from tester
> > or reviewer, should be added by author to the applicable patches when sending
> > next versions. However if the patch has changed substantially in following
> > version, these tags might not be applicable anymore and thus should be removed.
> > Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
> > in the patch changelog (after the '---' separator).
> >
> > Does this help you?
>
> Thanks so much, it does. My apologies to everyone whose reviewed-by tag I
> failed to add :(
>
> I should have read that more document more carefully.
No worries! The important part is your changes. The tags are easy
to add. And now you know. ;-)
Thanx, Paul