Re: [PATCH net-next v3] eth: fbnic: Add PCIe hardware statistics

[Bagas Sanjaya]

On Fri, Nov 08, 2024 at 12:46:40PM -0800, Sanman Pradhan wrote:
> diff --git a/Documentation/networking/device_drivers/ethernet/meta/fbnic.rst b/Documentation/networking/device_drivers/ethernet/meta/fbnic.rst
> index 32ff114f5c26..13ebcdbb5f22 100644
> --- a/Documentation/networking/device_drivers/ethernet/meta/fbnic.rst
> +++ b/Documentation/networking/device_drivers/ethernet/meta/fbnic.rst
> @@ -27,3 +27,29 @@ driver takes over.
>  devlink dev info provides version information for all three components. In
>  addition to the version the hg commit hash of the build is included as a
>  separate entry.
> +
> +PCIe Statistics
> +---------------
> +
> +The fbnic driver exposes PCIe hardware performance statistics through debugfs
> +(``pcie_stats``). These statistics provide insights into PCIe transaction
> +behavior and potential performance bottlenecks.
> +
> +Statistics Categories
> +
> +1. PCIe Transaction Counters:
> +
> +   These counters track PCIe transaction activity:
> +        - pcie_ob_rd_tlp: Outbound read Transaction Layer Packets count
> +        - pcie_ob_rd_dword: DWORDs transferred in outbound read transactions
> +        - pcie_ob_wr_tlp: Outbound write Transaction Layer Packets count
> +        - pcie_ob_wr_dword: DWORDs transferred in outbound write transactions
> +        - pcie_ob_cpl_tlp: Outbound completion TLP count
> +        - pcie_ob_cpl_dword: DWORDs transferred in outbound completion TLPs
> +
> +2. PCIe Resource Monitoring:
> +
> +   These counters indicate PCIe resource exhaustion events:
> +        - pcie_ob_rd_no_tag: Read requests dropped due to tag unavailability
> +        - pcie_ob_rd_no_cpl_cred: Read requests dropped due to completion credit exhaustion
> +        - pcie_ob_rd_no_np_cred: Read requests dropped due to non-posted credit exhaustion

The docs LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx>

-- 
An old man doll... just what I always wanted! - Clara

Attachment: signature.asc
Description: PGP signature