Re: [PATCH v4 1/1] memcg/hugetlb: Add hugeTLB counters to memcg

[David Rientjes]

On Fri, 1 Nov 2024, Joshua Hahn wrote:

> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 69af2173555f..bd7e81c2aa2b 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1646,6 +1646,11 @@ The following nested keys are defined.
>  	  pgdemote_khugepaged
>  		Number of pages demoted by khugepaged.
>  
> +	  hugetlb
> +		Amount of memory used by hugetlb pages. This metric only shows
> +		up if hugetlb usage is accounted for in memory.current (i.e.
> +		cgroup is mounted with the memory_hugetlb_accounting option).
> +
>    memory.numa_stat
>  	A read-only nested-keyed file which exists on non-root cgroups.
>  

Definitely makes sense to include this.

Any reason to not account different hugetlb page sizes separately in this 
stat, however?  IOW, should there be separate hugetlb_2048kB and 
hugetlb_1048576kB stats on x86?