Re: [PATCH v6 3/3] crypto: Add Mediatek EIP-93 crypto engine support

[Herbert Xu]

On Sat, Nov 02, 2024 at 06:50:35PM +0100, Christian Marangi wrote:
>
> +static int eip93_hash_import(struct ahash_request *req, const void *in)
> +{
> +	struct eip93_hash_reqctx *rctx = ahash_request_ctx(req);
> +	const struct eip93_hash_export_state *state = in;
> +	int ret;
> +
> +	ret = _eip93_hash_init(req, state->sa_state, state->sa_state_base);

You cannot export/import any kernel pointers.  The state is meant
to be a serialised version of the hash state.

So state->sa_state_base has got to go.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt