Re: [PATCH] enable the gpu node

[Bjorn Andersson]

On Sun, Nov 10, 2024 at 01:46:12PM +0100, maud spierings via B4 Relay wrote:

Please run 
  git log --oneline -- arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
and add a prefix to your subject line to make your change match others
to this file.

Please also drop "node", as it's the GPU you're actually enabling.

> From: maud spierings <maud_spierings@xxxxxxxxxxx>
> 
> enable the gpu node on the snapdragon powered asus vivobook s15

Looks good, please capitalize the 'e' at the beginning of your sentence.

> 
> ---

Anything below the '---' line is omitted from the git history,
including your Signed-off-by. So move that above this line (and remove
the "enables..."-line below.

> enables the gpu on the asus vivobook s15
> 
> Signed-off-by: maud spierings <maud_spierings@xxxxxxxxxxx>

It would make me happy if you capitalized the 'm' and 's' in your
name...

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> index 8515c254e15868a5d7f378b0dc0bf8f339fc7b19..f25991b887de3fca0092c5f81c881c5d8bd71aac 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> @@ -328,6 +328,14 @@ vreg_l3j_0p8: ldo3 {
>  	};
>  };
>  
> +&gpu {
> +	status = "okay";
> +
> +	zap-shader {
> +		firmware-name = "qcom/x1e80100/ASUSTeK/vivobook-s15/qcdxkmsuc8380.mbn";
> +	};
> +};
> +
>  &i2c0 {
>  	clock-frequency = <400000>;
>  	status = "okay";
> 
> ---
> base-commit: 929beafbe7acce3267c06115e13e03ff6e50548a
> change-id: 20241110-qcom-asus-gpu-870c7c22935c
> 
> Best regards,
> -- 
> maud spierings <maud_spierings@xxxxxxxxxxx>
> 
>