Re: [PATCH v4 2/6] iio: light: stk3310: handle all remove logic with devm callbacks

From: Andy Shevchenko
Date: Sun Nov 10 2024 - 14:51:40 EST


Sun, Nov 10, 2024 at 01:38:39PM -0500, Aren kirjoitti:
> On Mon, Nov 04, 2024 at 10:32:08AM +0200, Andy Shevchenko wrote:
> > On Sat, Nov 02, 2024 at 03:50:37PM -0400, Aren Moynihan wrote:

...

> > > + ret = devm_add_action_or_reset(&client->dev, stk3310_set_state_disable, data);
> >
> > Why not simply 'dev' as in below call?
>
> I was trying to avoid refactoring the entire function to replace
> &client->dev with dev, I'll add a patch for that to the next revision.

I'm not talking about refactoring, I'm talking only about the lines that you
have touched / added.

> > > + if (ret)
> > > + return dev_err_probe(dev, ret, "failed to register cleanup function\n");

--
With Best Regards,
Andy Shevchenko