Re: [PATCH -next] media: ipu6: Remove duplicated include in ipu6-dma.h

From: Bingbu Cao
Date: Sun Nov 10 2024 - 21:15:47 EST


Li,

Thanks for the patch.

On 11/11/24 9:56 AM, Yang Li wrote:
> The header files linux/iova.h is included twice in ipu6-dma.h,
> so one inclusion of each can be removed.
>
> ./drivers/media/pci/intel/ipu6/ipu6-dma.h: linux/iova.h is included more
> than once.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11791

It'd better to add:
Fixes: 799d91fd3fe0 ("media: ipu6: not override the dma_ops of device in driver")

> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---
> drivers/media/pci/intel/ipu6/ipu6-dma.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-dma.h b/drivers/media/pci/intel/ipu6/ipu6-dma.h
> index b51244add9e6..a902eec5c07a 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-dma.h
> +++ b/drivers/media/pci/intel/ipu6/ipu6-dma.h
> @@ -7,7 +7,6 @@
> #include <linux/dma-map-ops.h>
> #include <linux/dma-mapping.h>
> #include <linux/iova.h>
> -#include <linux/iova.h>
> #include <linux/scatterlist.h>
> #include <linux/types.h>
>
>

Reviewed-by: Bingbu Cao <bingbu.cao@xxxxxxxxx>


--
Best regards,
Bingbu Cao