Re: [PATCH net-next 2/2] net: ethernet: ti: am65-cpsw: enable DSCP to priority map for RX
From: Siddharth Vadapalli
Date: Mon Nov 11 2024 - 00:22:50 EST
On Sat, Nov 09, 2024 at 12:31:24PM +0200, Roger Quadros wrote:
>
>
> On 08/11/2024 16:42, Siddharth Vadapalli wrote:
> > On Fri, Nov 08, 2024 at 02:55:18PM +0200, Roger Quadros wrote:
> >> Hi Siddharth,
> >>
> >> On 08/11/2024 14:30, Siddharth Vadapalli wrote:
> >
> > [...]
> >
> >>>> +#define AM65_CPSW_PORTN_REG_CTL 0x004
> >>>
> >>> nitpick: indentation needs to be fixed here to align with the macros
> >>> below.
> >>
> >> It is fine in the code and in my editor in this reply email.
> >
> > That's strange. But it appears the same to me as seen at:
> > https://lore.kernel.org/r/20241105-am65-cpsw-multi-rx-dscp-v1-2-38db85333c88@xxxxxxxxxx/
> > where the indentation looks incorrect.
>
> It is probably editor specific. There are in fact 3 tab spaces to align it
> with the number.
>
> Can you please apply the patch and see if it is OK in the code?
I still see the indentation being off, but maybe it is just me seeing
this incorrectly.
Regards,
Siddharth.