Re: [PATCH v3] staging: greybus: uart: Fix atomicity violation in get_serial_info()

From: Dan Carpenter
Date: Mon Nov 11 2024 - 04:14:35 EST


On Thu, Nov 07, 2024 at 04:11:00PM +0100, Greg KH wrote:
> Hi,
>
> This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
> a patch that has triggered this response. He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created. Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
>
> You are receiving this message because of the following common error(s)
> as indicated below:
>
>
> - You have marked a patch with a "Fixes:" tag for a commit that is in an
> older released kernel, yet you do not have a cc: stable line in the
> signed-off-by area at all, which means that the patch will not be
> applied to any older kernel releases. To properly fix this, please
> follow the documented rules in the
> Documentation/process/stable-kernel-rules.rst file for how to resolve
> this.
>
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.

Like Johan said, this doesn't really belong in stable because it doesn't affect
users. It's mostly about correctness and static analysis.

The linux-media CI system has also started complaining if we don't add a stable
tag and it suggests that the correct thing is to add:

Cc: <stable+noautosel@xxxxxxxxxx> # reason goes here, and must be present

Do we really have to do that? Applying it to stable doesn't cause a problem,
it's just not necessary.

regards,
dan carpenter