Re: [PATCH] sched/topology: Correctly propagate NUMA flag to scheduling domains

From: Peter Zijlstra
Date: Mon Nov 11 2024 - 04:23:04 EST


On Sat, Nov 09, 2024 at 03:56:28PM +0100, Andrea Righi wrote:

> @@ -1974,6 +1981,7 @@ void sched_init_numa(int offline_node)
> */
> tl[i++] = (struct sched_domain_topology_level){
> .mask = sd_numa_mask,
> + .sd_flags = cpu_numa_flags,
> .numa_level = 0,
> SD_INIT_NAME(NODE)
> };

This doesn't seem right. This level is a single node, and IIRC we only
expect SD_NUMA on cross-node domains.