Re: [PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm

[Andreas Kemnade]

Am Mon, 4 Nov 2024 08:06:53 +0200
schrieb Matti Vaittinen <mazziesaccount@xxxxxxxxx>:

> On 01/11/2024 21:27, Rob Herring wrote:
> > On Tue, Oct 29, 2024 at 12:11:12PM +0100, Andreas Kemnade wrote:  
> >> Apparently there was some confusion regarding milliohm vs. megaohm.
> >> (m/M). Use microohms to be able to properly specify the charger
> >> resistor like other drivers do. This is not used yet by mainline code
> >> yet. Specify a current sense resistor in milliohms range rathes then
> >> megaohms range in the examples.  
> > 
> > milliohms?
> > 
> > rathes?
> >   
> >>
> >> CC: sre@xxxxxxxxxx
> >> Reported-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> >> Closes: https://lore.kernel.org/imx/6dcd724a-a55c-4cba-a45b-21e76b1973b0@xxxxxxxxx/T/#mf590875a9f4d3955cd1041d7196ff0c65c0a7e9d
> >> Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> >> ---
> >>   .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml  | 13 +++++++------
> >>   1 file changed, 7 insertions(+), 6 deletions(-)  
> > 
> > Looks like rohm,bd71815-pmic.yaml has the same problem.  
> 
> Yes! Thanks for pointing it out. I'll wait for a while if Andreas wants 
> to fix them both at the same go. I'll send a fix for BD71815 if I've not 
> seen one in a week or so :)
> 
There is more debris left from an apparently copy-paste-modify process
from bd71828. That should be checked. At least there are several
occurances of the BD71828 string in there. So a brush is needed.

Regards,
Andreas