RE: [PATCH 1/1] cdx: register shutdown callback for cdx controller

[Agarwal, Nikhil]

> -----Original Message-----
> From: Abhijit Gangurde <abhijit.gangurde@xxxxxxx>
> 
> register shutdown callback for cdx controller platform device to handle graceful
> connection closure of rpmsg transport.
> Also, handle shutdown of cdx bus device by disabling the bus.
> 
> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@xxxxxxx>
> ---
>  drivers/cdx/cdx.c                       | 5 ++++-
>  drivers/cdx/controller/cdx_controller.c | 6 ++++++
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c index 07371cb653d3..655a056bca4e
> 100644
> --- a/drivers/cdx/cdx.c
> +++ b/drivers/cdx/cdx.c
> @@ -338,8 +338,11 @@ static void cdx_shutdown(struct device *dev)  {
>  	struct cdx_driver *cdx_drv = to_cdx_driver(dev->driver);
>  	struct cdx_device *cdx_dev = to_cdx_device(dev);
> +	struct cdx_controller *cdx = cdx_dev->cdx;
> 
> -	if (cdx_drv && cdx_drv->shutdown)
> +	if (cdx_dev->is_bus && cdx_dev->enabled && cdx->ops->bus_disable)
> +		cdx->ops->bus_disable(cdx, cdx_dev->bus_num);
> +	else if (cdx_drv && cdx_drv->shutdown)
>  		cdx_drv->shutdown(cdx_dev);
Please drop else from here.

Also, as suggested by Greg, please split this patch into 2 separate patches 
for device shutdown and controller shutdown.